[Menu] Update tab navigation on win32 #3860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurikoaraki
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
On win32, tab should only navigate between MenuGroups, not to individual MenuItems, for efficient navigation. This change updates the tab navigation for FURN Menu to check if the Menu has any MenuGroups before enabling tab navigation. If there are no MenuGroups present, only arrow keys will navigate to menu items within the Menu.
Verification
Manually tested by using tab on Menu without MenuGroups.
Tab would visit every menu item before changes. Tab does not visit additional menu items after placing focus on the first item after changes.
Tab will visit the first/last item in a MenuGroup when MenuGroups are present (depending if user uses Tab/Shift+Tab) which is the same before/after changes:
Pull request checklist
This PR has considered (when applicable):